Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update title for Sync to include (beta) #1441

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Update title for Sync to include (beta) #1441

merged 1 commit into from
Jan 24, 2019

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Jan 24, 2019 •
edited
Loading

Fixes brave/brave-browser#3079

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. With Sync disabled, visit chrome://sync/
  2. Verify title for Sync includes (beta)
  3. Enable sync
  4. Verify title for Sync includes (beta)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bsclifton bsclifton added this to the 0.62.x - Nightly milestone Jan 24, 2019
@rebron rebron mentioned this pull request Jan 24, 2019
Closed
@bsclifton bsclifton merged commit 3e952ba into master Jan 24, 2019
@bsclifton bsclifton deleted the sync-title-update branch January 24, 2019 21:06
rossmoody pushed a commit that referenced this pull request Jan 24, 2019
@bsclifton
Merge pull request #1441 from brave/sync-title-update
28d9992 
Update title for Sync to include (beta)
@rossmoody rossmoody mentioned this pull request Jan 24, 2019
Merged
rossmoody pushed a commit that referenced this pull request Jan 24, 2019
@bsclifton
Merge pull request #1441 from brave/sync-title-update
5811e7a 
Update title for Sync to include (beta)
rossmoody pushed a commit that referenced this pull request Jan 24, 2019
@bsclifton
Merge pull request #1441 from brave/sync-title-update
c87308e 
Update title for Sync to include (beta)
This was referenced Jan 24, 2019
Merged
Merged
@GeetaSarvadnya
Copy link

@rebron Step1, should it be With Sync Enabled, visit chrome://sync/?

bsclifton added a commit that referenced this pull request Jan 25, 2019
@bsclifton
Revert "Merge pull request #1441 from brave/sync-title-update"
bcff4e5 
This reverts commit 3e952ba, reversing
changes made to eefa3f7.
bsclifton added a commit that referenced this pull request Jan 25, 2019
@bsclifton
Revert "Merge pull request #1441 from brave/sync-title-update"
18dff57 
This reverts commit 3e952ba, reversing
changes made to eefa3f7.
bsclifton added a commit that referenced this pull request Jan 25, 2019
@bsclifton
Revert "Merge pull request #1441 from brave/sync-title-update"
bf17279 
This reverts commit 3e952ba, reversing
changes made to eefa3f7.
bsclifton added a commit that referenced this pull request Jan 25, 2019
@bsclifton
Revert "Merge pull request #1441 from brave/sync-title-update"
567c7ef 
This reverts commit 3e952ba, reversing
changes made to eefa3f7.
@NejcZdovc NejcZdovc mentioned this pull request Jan 25, 2019
Closed
@kjozwiak
Copy link
Member

@rebron Step1, should it be With Sync Enabled, visit chrome://sync/?

I think what @bsclifton meant is visiting brave://sync while there's no sync chain and making sure that the title displays the new Beta string. Once that's verified, create a sync chain and make sure that the title still correctly uses Beta.

@AlexeyBarabash AlexeyBarabash mentioned this pull request Dec 1, 2020
Merged
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

@kjozwiak kjozwiak Awaiting requested review from kjozwiak

@rebron rebron Awaiting requested review from rebron

@NejcZdovc NejcZdovc Awaiting requested review from NejcZdovc

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@bsclifton bsclifton

@rossmoody rossmoody

Labels
None yet
Projects
None yet
Milestone
0.62.x - Release
Development

Successfully merging this pull request may close these issues.

add Beta label for Sync
5 participants
@bsclifton @GeetaSarvadnya @kjozwiak @bbondy @rossmoody